RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v9]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Wed Aug 16 06:01:45 UTC 2023
On Tue, 15 Aug 2023 14:41:16 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Duplicate code removal
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 630:
>
>> 628: pHeight = Math.max(0, getHeight());
>> 629: Graphics g = getGraphics();
>> 630: double newScaleFactorX = getCurrentTransform().getScaleX();
>
> minor (here and later): unless optimized away by the compiler, this code invokes getCurrentTransform() twice. Would it make sense to introduce a local variable?
>
> AffineTransform t = getCurrentTransform();
> double sx = t.getScaleX();
> double sy = t.getScaleY();
ok
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1171#discussion_r1295410243
More information about the openjfx-dev
mailing list