RFR: 8310885: Width/height of window is not set after calling sizeToScene [v2]
Marius Hanl
mhanl at openjdk.org
Wed Aug 16 07:11:20 UTC 2023
On Tue, 8 Aug 2023 09:02:07 GMT, Guillaume Tâche <duke at openjdk.org> wrote:
>> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and before `show()`.
>> Now the `sizeToScene` flag is unset in these methods to ensure the right values are set when the window is shown.
>
> Guillaume Tâche has updated the pull request incrementally with one additional commit since the last revision:
>
> 8310885: Fixes review comment
modules/javafx.graphics/src/test/java/test/javafx/stage/WindowTest.java line 184:
> 182: testWindow.setWidth(800);
> 183: testWindow.show();
> 184: assertEquals(800, testWindow.getWidth(), 1);
I think you can remove the delta in this tests. We expect accurate numbers here
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1195#discussion_r1295467845
More information about the openjfx-dev
mailing list