RFR: 8310885: Width/height of window is not set after calling sizeToScene [v2]

Guillaume Tâche duke at openjdk.org
Wed Aug 16 09:29:00 UTC 2023


On Wed, 16 Aug 2023 07:08:10 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> Guillaume Tâche has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8310885: Fixes review comment
>
> modules/javafx.graphics/src/test/java/test/javafx/stage/WindowTest.java line 184:
> 
>> 182:         testWindow.setWidth(800);
>> 183:         testWindow.show();
>> 184:         assertEquals(800, testWindow.getWidth(), 1);
> 
> I think you can remove the delta in this tests. We expect accurate numbers here

Done, indeed it also works with exact comparisons.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1195#discussion_r1295622629


More information about the openjfx-dev mailing list