RFR: 8310885: Width/height of window is not set after calling sizeToScene [v3]

Marius Hanl mhanl at openjdk.org
Wed Aug 16 12:03:16 UTC 2023


On Wed, 16 Aug 2023 09:28:57 GMT, Guillaume Tâche <duke at openjdk.org> wrote:

>> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and before `show()`.      
>> Now the `sizeToScene` flag is unset in these methods to ensure the right values are set when the window is shown.
>
> Guillaume Tâche has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8310885: Uses exact comparison for tests

Looks good to me too.

-------------

Marked as reviewed by mhanl (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1195#pullrequestreview-1580434274


More information about the openjfx-dev mailing list