RFR: 8314212: Crash when loading cnn.com in WebView [v2]

[Jay Bhaskar]

On Thu, 17 Aug 2023 11:44:04 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   clean up according to review comments
>
> modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/MediaPlayerPrivateJava.cpp line 436:
> 
>> 434:     // in case of hls media m3u8 format check network state
>> 435:     // since jfx media do not support hls live streaming protocol
>> 436:     if ( MediaPlayerNetworkState::NetworkError == MediaPlayer::NetworkState::NetworkError)
> 
> Are there other errors that might occur, or is this the only one you need to check?
> 
> Minor: delete the extra space after the `(`.

done

> modules/javafx.web/src/main/native/Source/WebCore/rendering/RenderLayerCompositor.cpp line 1201:
> 
>> 1199: // in case of video data format like m3u8 error case ,check if layer needs compositing
>> 1200: #if PLATFORM(JAVA)
>> 1201:     if(willBeComposited != needsToBeComposited(layer, queryData))
> 
> Minor: add extra space after `if`.

done

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1212#discussion_r1297245411
PR Review Comment: https://git.openjdk.org/jfx/pull/1212#discussion_r1297245649