RFR: 8313956: focusWithin on parents of a newly-added focused node is not updated [v2]

Ambarish Rapte arapte at openjdk.org
Fri Aug 18 07:20:36 UTC 2023


On Thu, 17 Aug 2023 00:30:45 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> This PR fixes an issue with the way `focusWithin` bits are adjusted in the scene graph. Previously, the `focusWithin` counts of all parents of a removed node would be decreased if the removed node has a non-zero `focusWithin` count. This PR adds logic for the opposite scenario: the `focusWithin` count is increased on all parents of a newly-added node that is already focused (or contains other focused nodes).
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unnecessary code

Marked as reviewed by arapte (Reviewer).

Looks all neat to me. The FocusTest does cover a variety of scenarios.
The change is specific to FocusWithin and seems unlikely to have any side effects.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1210#pullrequestreview-1583992072
PR Comment: https://git.openjdk.org/jfx/pull/1210#issuecomment-1683464510


More information about the openjfx-dev mailing list