RFR: 8313709: Wrong layout of a FlowPane in a BorderPane in a ScrollPane, if padding is too big [v2]

[Jose Pereda]

On Wed, 16 Aug 2023 21:26:21 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Migrate old tests to JUnit 5
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/BorderPane.java line 395:
> 
>> 393: 
>> 394:             double middleAreaHeight = Math.max(0,
>> 395:                     height - insets.getTop() - insets.getBottom() - topPrefHeight - bottomPrefHeight);
> 
> should these be snapped?  snappedBottomInset() etc.?

You might be right. 

In this case, `topPrefHeight` comes from `getAreaHeight()`, that calls `computeChildPrefAreaHeight()` that ultimately uses `snapSpaceY()`. 

However, this would also mean that the returned value should use snapped insets as well?

return insets.getLeft() +
                Math.max(leftPrefWidth + centerMinWidth + rightPrefWidth, Math.max(topMinWidth,bottomMinWidth)) +
                insets.getRight();

and also for the layout call?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1203#discussion_r1298697529