RFR: 8313709: Wrong layout of a FlowPane in a BorderPane in a ScrollPane, if padding is too big [v2]
Kevin Rushforth
kcr at openjdk.org
Fri Aug 18 18:31:33 UTC 2023
On Fri, 18 Aug 2023 18:04:14 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Please, see my edited comment. If we are to change to snapped values _everywhere_ (not only in the proposed fix of this PR), that would be a broader change...
>
> no, I did not propose to change it everywhere.
> In this PR, in the code we change, we probably should [start to] use snapped coordinates. wouldn't you agree?
Hard to say. Unless it's somehow related to the changes being made, I can see a good argument for addressing the snapping in a follow-up issue, so as not to introduce what is essentially an unrelated fix.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1203#discussion_r1298740921
More information about the openjfx-dev
mailing list