RFR: 8313956: focusWithin on parents of a newly-added focused node is not updated [v3]

Michael Strauß mstrauss at openjdk.org
Fri Aug 18 20:45:01 UTC 2023


On Fri, 18 Aug 2023 20:25:53 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Correctly handle added node with multiple focuses
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/FocusTest.java line 1146:
> 
>> 1144:         node3 = new N(
>> 1145:             node4 = new N());
>> 1146: 
> 
> ignore: I think this looks a bit inconsistent (in the first version not all parenthesis are closed on the last line, while they are in the second version).  Personally I favor this, similar to how curly braces are used):
> Suggestion:
> 
>         scene.setRoot(
>             node1 = new N(
>                 node2 = new N()
>             )
>         );
> 
>         node3 = new N(
>             node4 = new N()
>         );

Done.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1210#discussion_r1298849544


More information about the openjfx-dev mailing list