RFR: 8313651: Add 'final' keyword to public property methods in controls [v2]

Andy Goryachev angorya at openjdk.org
Fri Aug 18 22:17:18 UTC 2023


On Fri, 18 Aug 2023 22:04:11 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java line 216:
> 
>> 214:                 sb.append(c);
>> 215:             }
>> 216:         }
> 
> Suggestion:
> 
>        sb.append(prefix);
>        sb.append(Character.toUpperCase(name.charAt(0)));
>        sb.append(name, 1, name.length);

good idea, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1298896375


More information about the openjfx-dev mailing list