RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v6]

[Andy Goryachev]

On Mon, 21 Aug 2023 14:01:06 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> The text run selected in `PrismTextLayout::getHitInfo()` method for character index calculation was not correct when Text node was embedded in TextFlow. Hence wrong character index value was calculated for the same.
>> 
>> Since only x, y coordinates were available in the above mentioned method, sending the text as a parameter to this method is necessary so as to know if the text run selected for character index calculation is correct. Along with this change modified the `PrismTextLayout::getHitInfo()` method to calculate the correct character index.
>> 
>> Added tests to validate the changes.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java line 782:

> 780:     }
> 781: 
> 782: 

is there an unnecessary newline here?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1157#discussion_r1300209159