RFR: 8313650: Add hasProperties method to MenuItem and Toggle [v3]

Andy Goryachev angorya at openjdk.org
Mon Aug 21 15:56:59 UTC 2023


> 1. Creating a new `javafx.scene.ContainsProperties` interface that declares two methods:
> - public ObservableMap<Object, Object> getProperties();
> - public boolean hasProperties();
> 
> 2. Node, MenuItem, and Toggle now extend ContainsProperties interface.
> 
> 3. Making implemented methods in Node, MenuItem, and Toggle final.
> 
> This change requires CSR.

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - javadoc
 - contains properties interface
 - Merge remote-tracking branch 'origin/master' into 8313650.properties
 - review comments
 - test
 - has properties

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1215/files
  - new: https://git.openjdk.org/jfx/pull/1215/files/dce85ebc..cd643cfd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1215&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1215&range=01-02

  Stats: 273 lines in 10 files changed: 187 ins; 47 del; 39 mod
  Patch: https://git.openjdk.org/jfx/pull/1215.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1215/head:pull/1215

PR: https://git.openjdk.org/jfx/pull/1215


More information about the openjfx-dev mailing list