RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v7]

Andy Goryachev angorya at openjdk.org
Mon Aug 21 18:25:08 UTC 2023


On Mon, 21 Aug 2023 18:20:17 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> The text run selected in `PrismTextLayout::getHitInfo()` method for character index calculation was not correct when Text node was embedded in TextFlow. Hence wrong character index value was calculated for the same.
>> 
>> Since only x, y coordinates were available in the above mentioned method, sending the text as a parameter to this method is necessary so as to know if the text run selected for character index calculation is correct. Along with this change modified the `PrismTextLayout::getHitInfo()` method to calculate the correct character index.
>> 
>> Added tests to validate the changes.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

thank you for addressing the comments!  lgtm now.

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1157#pullrequestreview-1587615229


More information about the openjfx-dev mailing list