RFR: 8313651: Add 'final' keyword to public property methods in controls [v2]

[Andy Goryachev]

On Mon, 21 Aug 2023 22:16:12 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Thank you for suggestions!
>> 
>> Frankly, I don't see much value in rewriting of this method.  A more interesting problem is how to enumerate all descendants of the Control class  using the package name, in such a way that will reliably work in an IDE, from a JAR, or in any test framework (jtreg or otherwise).
>> 
>> edit: about the test itself - I see little difference between the two version, but will gladly use your version if you feel strongly about it.
>
>> edit: about the test itself - I see little difference between the two version, but will gladly use your version if you feel strongly about it.
> 
> I don't, I just think it's more readable. Fine to leave as is. What I might strongly suggest is extracting the `checkModifiers` method that is used in 2 places in your version.

done, and also fixed a stupid mistake ... method names are not unique.
many thanks!

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1300735307