RFR: 8283675: Line not removed from LineChart when series cleared
Andy Goryachev
angorya at openjdk.org
Tue Aug 22 15:11:49 UTC 2023
On Fri, 18 Aug 2023 07:25:28 GMT, Karthik P K <kpk at openjdk.org> wrote:
> The issue is present in AreaChart along with the LineChart. Issue is fixed in both the charts as part of this PR.
> The line elements in case of Line chart and both line element and fill element in the case of Area charts were not cleared in `makePaths()` method in AreaChart.java. Hence the line and fill area were not getting cleared when series was cleared.
>
> Made changes in code to clear line element and fill element as required in the `makePaths()` method.
>
> Added tests to validate the changes in both LineChart and AreaChart.
This looks good, with 2 more tickets out of scope for this PR.
Could we have another reviewer to take a look please?
-------------
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1214#pullrequestreview-1589678151
More information about the openjfx-dev
mailing list