RFR: 8313651: Add 'final' keyword to public property methods in controls [v4]

Andy Goryachev angorya at openjdk.org
Tue Aug 22 15:37:17 UTC 2023


On Tue, 22 Aug 2023 05:51:32 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java line 98:
> 
>> 96: public class ControlPropertiesTest {
>> 97: 
>> 98:     private static final boolean FAIL_FAST = !true;
> 
> Did you intend to commit this?  It was `true` before which seems good for tests, otherwise I'd really suggest using `false` here.

sorry, committed by accident.  thanks for noticing!

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1301801316


More information about the openjfx-dev mailing list