RFR: 8313651: Add 'final' keyword to public property methods in controls [v4]

Andy Goryachev angorya at openjdk.org
Tue Aug 22 15:39:18 UTC 2023


On Tue, 22 Aug 2023 09:13:08 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java line 172:
> 
>> 170:     @Test
>> 171:     public void testMissingFinalMethods() {
>> 172:         for (Class c: allControlClasses()) {
> 
> I think we use a space before `:`. Don't know if it's being enforced. If you change it there are 2 more places.

Adding superfluous spaces increases our carbon footprint ;-)
Modified the formatter to increase the footprint.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1301807735


More information about the openjfx-dev mailing list