RFR: 8311097: Synchron XMLHttpRequest not receiving data

Kevin Rushforth kcr at openjdk.org
Thu Aug 31 14:42:11 UTC 2023


On Wed, 30 Aug 2023 14:32:37 GMT, Andrew Brygin <bae at openjdk.org> wrote:

> This issue is a regression from  7e48413eb0 8285881: Update WebKit to 614.1. For synchronous requests, we have an additional buffer to collect data, and the appending data into this buffer is doing in a wrong way:  we use Vector::append(U&& u), which adds only the first data element. Instead, we should use Vector::append(const U* u, size_t size) in order to add all obtained data.
> 
> I have added the test for this issue to LoadTest.java

Looks good. I also confirm that the new test fails without the fix and passes with the fix.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1227#pullrequestreview-1604921944


More information about the openjfx-dev mailing list