RFR: 8282290: TextField Cursor Position one off [v2]

Karthik P K kpk at openjdk.org
Fri Dec 1 14:28:46 UTC 2023


On Thu, 30 Nov 2023 17:47:40 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Code review
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java line 248:
> 
>> 246:         textNode.caretShapeProperty().addListener(observable -> {
>> 247:             caretPath.getElements().setAll(textNode.caretShapeProperty().get());
>> 248:             if (caretPath.getElements().size() != 4) {
> 
> could you add a comment explaining why != 4 is here for the future reference.

Added comment

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1287#discussion_r1412164025


More information about the openjfx-dev mailing list