RFR: 8092272: [D3D 3D] Need a robust 3D states management for texture [v2]

Nir Lisker nlisker at openjdk.org
Fri Dec 1 16:57:27 UTC 2023


On Fri, 1 Dec 2023 09:14:28 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed review comments
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DContext.cc line 367:
> 
>> 365: {
>> 366:     static const std::array<D3DTEXTUREFILTERTYPE, 2> minMagEnumMap = { D3DTEXF_POINT, D3DTEXF_LINEAR };
>> 367:     static const std::array<D3DTEXTUREFILTERTYPE, 3> mipmapEnumMap = { D3DTEXF_NONE, D3DTEXF_POINT, D3DTEXF_LINEAR };
> 
> I think these should be class or file level arrays or enums instead of here.

They are used only in this method. Why would like them to be moved out?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1281#discussion_r1412360151


More information about the openjfx-dev mailing list