RFR: 8301302: Platform preferences API [v34]

[Michael Strauß]

On Thu, 30 Nov 2023 23:38:18 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   initialize field with NULL
>
> modules/javafx.graphics/src/main/native-glass/win/GlassApplication.cpp line 189:
> 
>> 187:                 return 0;
>> 188:             }
>> 189:             break;
> 
> In the case of `WM_THEMECHANGED` we used to always return and not exit the switch statement. Could this cause any problems?

Like with `WM_SETTINGCHANGE`, the documentation for [WM_THEMECHANGED](https://learn.microsoft.com/en-us/windows/win32/winmsg/wm-themechanged) states that applications should return zero if they process the message. I think it's good practice to do so, as otherwise Windows wouldn't be aware that we processed the message, causing potential behavioral changes if the default window procedure is changed in future OS releases.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1412691479