RFR: 8301302: Platform preferences API [v43]

Wed Dec 6 21:31:40 UTC 2023

On Wed, 6 Dec 2023 20:38:46 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Please read [this document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for an introduction to the Platform Preferences API, and how it interacts with the proposed style theme and stage appearance features.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
> 
>   swap message fields

> Looks like it's sending changes for values that have not changed:
> 
> <img alt="Screenshot 2023-12-06 at 11 30 04" width="1170" src="https://private-user-images.githubusercontent.com/107069028/288525653-e7591236-f882-4ce9-9877-841f5441af71.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDE4OTM5MDIsIm5iZiI6MTcwMTg5MzYwMiwicGF0aCI6Ii8xMDcwNjkwMjgvMjg4NTI1NjUzLWU3NTkxMjM2LWY4ODItNGNlOS05ODc3LTg0MWY1NDQxYWY3MS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBSVdOSllBWDRDU1ZFSDUzQSUyRjIwMjMxMjA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDIzMTIwNlQyMDEzMjJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jYjc5OWFkMDc4M2E4ZGQ2ZDM4NzlhNWE5NjU4MmNmMGI5MjgxZGM0NDlkMzZkZTc0Nzk5ODZiNTUwZGUyN2M2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.MZzm5skzw6jR3CHmcEkvulWMiG8upYXkKIRCawodSpM">
> To reproduce on macOS 13.5.2: change System Settings -> Appearance -> Accent Color from green to yellow.
> 
> I don't expect `macOS.NSColor.alternatingContentBackgroundColors=[0xffffffff, 0xf4f5f5ff]` to be sent because it has not changed.

Turns out that this was a bug in the test application. It didn't print the actual content of the change notification, but did its own comparison of the entire map. I've updated the test application so that it prints exactly what's in the notification.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1014#issuecomment-1843719549