RFR: 8301302: Platform preferences API [v46]

[Michael Strauß]

On Thu, 7 Dec 2023 08:45:43 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

> There are classes such as `PlatformPreferences`, `PreferenceProperties`, and `ColorSchemeProperty` that are effectively singletons. Does it makes sense to just write them in a singleton pattern to avoid misuse?

If we add user-modifiable preferences, these won't be singletons.

> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 587:
> 
>> 585: 
>> 586:         /**
>> 587:          * The color used for background regions.
> 
> Maybe "The color used for background **of** regions"?

But not all regions are backgrounds in this sense.

> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 611:
> 
>> 609: 
>> 610:         /**
>> 611:          * The accent color.
> 
> I think that this needs to explanation on what the accent color is.

I'll create a follow-up issue for that.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1014#issuecomment-1845786750
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1419332384
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1419336136