RFR: 8301302: Platform preferences API [v47]

Michael Strauß mstrauss at openjdk.org
Thu Dec 7 18:33:26 UTC 2023


On Thu, 7 Dec 2023 18:17:58 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - removed unused import
>>  - javadoc
>>  - query resource bundles for high-contrast schemes only on Windows
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/WindowsHighContrastScheme.java line 43:
> 
>> 41:  * The high contrast feature may not be available on all platforms.
>> 42:  */
>> 43: enum WindowsHighContrastScheme {
> 
> I'd rather keep the old name: `HighContrastScheme`: It is in a non-platform specific package, and it applies to all platforms (even only with `NONE`).
> You could add a comment about `HIGH_CONTRAST_*` enum constants being only available on Windows.

But it never applied to all platforms, it reflects exactly the Windows implementation of high-contrast schemes. It will be moved once we add style themes.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1419444090


More information about the openjfx-dev mailing list