RFR: 8321573: Improve Platform.Preferences documentation [v2]

Michael Strauß mstrauss at openjdk.org
Sat Dec 9 08:40:34 UTC 2023


On Sat, 9 Dec 2023 07:25:17 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   wording, table styling
>
> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 612:
> 
>> 610:          * The accent color, which is usually a vivid color that contrasts with the foreground
>> 611:          * and background colors. It can be used to highlight the active or important part of a
>> 612:          * control and make it stand out from the rest of the user interface.
> 
> I think it's more important to say what it's used for than what value is should have, so I would switch the order:
> 
> The accent color, which can be used to highlight the active or important part of a
> control and make it stand out from the rest of the user interface. It is usually a vivid
> color that contrasts with the foreground and background colors.

Yes, that's better.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1301#discussion_r1421359899


More information about the openjfx-dev mailing list