RFR: 8321573: Improve Platform.Preferences documentation [v2]

Nir Lisker nlisker at openjdk.org
Sat Dec 9 09:36:24 UTC 2023


On Sat, 9 Dec 2023 08:40:31 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> This PR enhances the documentation of `Platform.Preferences.accentColor`:
>> 
>> 
>>    /**
>> -   * The accent color.
>> +   * The accent color, which can be used to highlight the active or important part of a
>> +   * control and make it stand out from the rest of the user interface. It is usually a
>> +   * vivid color that contrasts with the foreground and background colors.
>> 
>> 
>> Additional changes include alternating row colors for tables.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
> 
>   wording, table styling

Looks good. Let's keep it open until Monday to give others a chance to review.

modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 596:

> 594:          * The color used for background regions.
> 595:          * <p>
> 596:          * If the platform does not report a background color, this property defaults to {@link Color#WHITE}.

Minor: I don't think you need a link here because it's linked in the default value tag.

-------------

Marked as reviewed by nlisker (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1301#pullrequestreview-1773646552
PR Review Comment: https://git.openjdk.org/jfx/pull/1301#discussion_r1421378662


More information about the openjfx-dev mailing list