RFR: 8320965: Scrolling on a touch enabled display fails on Wayland
Jose Pereda
jpereda at openjdk.org
Thu Dec 14 20:15:54 UTC 2023
On Thu, 14 Dec 2023 16:02:48 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and wrapped functions for GTK 3.20+ (so systems without it still run with GTK 3.8+), and fixes the dragging issue on Wayland.
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_general.cpp line 599:
>
>> 597: return TRUE;
>> 598: }
>> 599: #if GTK_CHECK_VERSION(3, 20, 0)
>
> I wouldn't have expected any compile-time `#if` checks as part of this PR.
Okay, that makes sense.
I've removed the compile-time `#if-#else` from `wrapped.c`.
However, to do the same in `glass_general.cpp`, if the wrapped functions fail (when dlsym returns null), we still need to fall back to the old implementation, don't we?
Therefore, I've changed the signature to return a `gboolean` (and removed the `GDK_GRAB_FAILED` enum value that was added in 3.16, as I just noticed).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1305#discussion_r1427224949
More information about the openjfx-dev
mailing list