RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]

Thiago Milczarek Sayao tsayao at openjdk.org
Sat Dec 16 22:24:49 UTC 2023


On Thu, 14 Dec 2023 20:19:12 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and wrapped functions for GTK 3.20+ (so systems without it still run with GTK 3.8+), and fixes the dragging issue on Wayland.
>
> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove compile-time if checks

modules/javafx.graphics/src/main/native-glass/gtk/wrapped.c line 197:

> 195:         return TRUE;
> 196:     }
> 197:     return FALSE;

I did try to test on Ubuntu 16.04 and compilation failed (no surprise because `GdkSeat` does not exists there). Suggestion to keep  `#ifdef` here and `return FALSE` on `#else` so it would still compile on Ubuntu 16.04 and older systems. Will need to `#ifdef` all `GdkSeat` usage.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1305#discussion_r1428953396


More information about the openjfx-dev mailing list