RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v13]

[Thiago Milczarek Sayao]

On Wed, 13 Dec 2023 19:22:49 GMT, Martin Fox <mfox at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Account the case of !filtered
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 486:
> 
>> 484:     CHECK_JNI_EXCEPTION(mainEnv)
>> 485: 
>> 486:     if (press && key > 0) { // TYPED events should only be sent for printable characters.
> 
> A handler for the PRESS event might close the window. In that case `jview` will be set to zero before you send out the TYPED event. You should do another check for that here.
> 
> See [JDK-8301219](https://bugs.openjdk.org/browse/JDK-8301219) for some sample code. I'll be submitting a fix for that bug just as soon as I get a test case working reliably.

There's a check before.


    if (!jview) {
        return;
    }

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1428971893