RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v13]

Thiago Milczarek Sayao tsayao at openjdk.org
Sun Dec 17 11:14:56 UTC 2023


On Wed, 13 Dec 2023 19:09:44 GMT, Martin Fox <mfox at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Account the case of !filtered
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window_ime.cpp line 120:
> 
>> 118:     if (!filtered || (filtered && im_ctx.send_keypress)) {
>> 119:         process_key(&event->key);
>> 120:         im_ctx.send_keypress = false;
> 
> I'm seeing two RELEASE events on each keystroke. If you call process_key() here you need to set `filtered` to true to ensure the event isn't processed again.

I changed to "if not filtered", just propagate.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1429127179


More information about the openjfx-dev mailing list