RFR: 8321970: New table columns don't appear when using fixed cell size unless refreshing tableView [v2]
Jose Pereda
jpereda at openjdk.org
Mon Dec 18 15:51:04 UTC 2023
On Mon, 18 Dec 2023 14:13:51 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:
>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>>
>> address feedback
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableRowSkinTest.java line 87:
>
>> 85: tableView.setItems(items);
>> 86:
>> 87: stageLoader = new StageLoader(new Scene(tableView));
>
> this changes the context of unrelated tests - no idea whether or not it matters, but I would try not to :)
Good catch, actually this changes is a leftover after some changes I did while getting the test to fail... but now I see it is not needed after all.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1308#discussion_r1430332070
More information about the openjfx-dev
mailing list