RFR: 8138842: TableViewSelectionModel.selectIndices does not select index 0 [v2]

Andy Goryachev angorya at openjdk.org
Wed Feb 1 16:12:07 UTC 2023


On Wed, 1 Feb 2023 06:37:21 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> In `selectIndices` method, zero length array is not considered while ignoring row number given as parameter.
>> 
>> Updated the code to consider both null and zero length array in the condition before ignoring the row value given as parameter.
>> 
>> Added unit test to validate the fix
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix first index selection issue in TreeTableView

I don't think null should throw an NPE in this case.
Thank you Karthik for writing unit tests.
LGTM

-------------

Marked as reviewed by angorya (Committer).

PR: https://git.openjdk.org/jfx/pull/1018


More information about the openjfx-dev mailing list