RFR: 8301604: Replace Collections.unmodifiableList with List.of [v2]

Nir Lisker nlisker at openjdk.org
Wed Feb 1 23:45:37 UTC 2023


On Wed, 1 Feb 2023 23:38:57 GMT, Glavo <duke at openjdk.org> wrote:

>> `List.of` is cleaner, and can slightly reduce the memory footprint for lists of one or two elements.
>> 
>> Because `List.of` can only store non-null elements, I have only replaced a few usage.
>> 
>> Can someone open an Issue on JBS for me?
>
> Glavo has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update FileChooser
>  - Update getTracks

You can put the argument list of the constructors and methods in one line. Also the `IllegalArgumentException` and its message can be in the same line.

After you add the empty lines after the `FileChooser` class declaration and the `ExtensionFilter` class declaration this can go in.

-------------

PR: https://git.openjdk.org/jfx/pull/1012


More information about the openjfx-dev mailing list