RFR: 8230833: LabeledSkinBase computes wrong height with ContentDisplay.GRAPHIC_ONLY [v2]

Karthik P K kpk at openjdk.org
Thu Feb 2 07:48:44 UTC 2023


On Wed, 18 Jan 2023 06:56:57 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> Ignore text condition was not considered in `computePrefHeight` method while calculating the Label height.
>> 
>> Added `isIgnoreText` condition in `computePrefHeight` method while calculating Label height.
>> 
>> Tests are present for all the ContentDisplay types. Modified tests which were failing because of the new height value getting calculated.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use width while calling prefHeight method. Use graphicHeight instead of multiple calls to prefHeight

@andy-goryachev-oracle please take a look at this PR and let me know if you have any comments on this.

-------------

PR: https://git.openjdk.org/jfx/pull/996


More information about the openjfx-dev mailing list