RFR: 8298382: JavaFX ChartArea Accessibility Reader [v2]

Andy Goryachev angorya at openjdk.org
Thu Feb 2 18:11:43 UTC 2023


On Thu, 2 Feb 2023 18:06:51 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Sorry for accidentally editing your comment. I think I restored it correctly.
>
>> one way to do it is to describe the expected result in the comment immediately preceding the string.
>> ...
>> 
>> Also, for testing purposes, we could consider pseudolocalization
> 
> These are good suggestions that should be captured in the follow-up issue that Alex said he will file.
> 
> Localization and testing is out of scope for this PR. Alex did the minimum needed to correct the fact that the string wasn't internationalized at all, which makes sense only because he had to modify the string as part of this PR (even then, I would have been OK with no i18n changes in this PR, leaving them for a separate issue as well).
> 
>> Better discuss this with Naoto Sato.
> 
> Good idea.

Definitely out of scope for this PR, I just wanted to mention this.
@azuev-java please link the follow up JBS ticket for localization.
Thank you!

-------------

PR: https://git.openjdk.org/jfx/pull/1016


More information about the openjfx-dev mailing list