RFR: 8298382: JavaFX ChartArea Accessibility Reader [v5]

Kevin Rushforth kcr at openjdk.org
Fri Feb 3 14:12:21 UTC 2023


On Fri, 3 Feb 2023 00:37:56 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>>> Still, I would recommend adding a comment (since now is the time when we know all the context, and in the future we might forget or lose the context), may be something like
>> 
>> Good idea, let me do it for both strings with parameters
>
> sorry to hold up the review - I'll speak to Naoto Sato tomorrow (2/3/23 @ 11:00) regarding the requirements for translation hints, and either approve or let you know what they expect us to do.

OK. Presuming that the comment Alex already left is fine, or just needs a slight format change, then that's good. If it's more than that, it would be better to do it in a follow-up issue.

-------------

PR: https://git.openjdk.org/jfx/pull/1016


More information about the openjfx-dev mailing list