[jfx20] RFR: 8301797: Pagination control has the wrong size

Kevin Rushforth kcr at openjdk.org
Fri Feb 3 21:51:02 UTC 2023


On Fri, 3 Feb 2023 20:15:46 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Fixed regression introduced by JDK-8295754, targeting upstream **jfx20 branch**.
> 
> The method PaginationSkin.resetIndexes(true) has been moved to the original position in the constructor, fixing the initialization, while making sure no properties of the control are touched in the constructor (only in install()).
> 
> Added a test case.
> 
> Tested with the PaginationDisappear.java and the LeakTest app
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTestApp.java

A fix request in JBS is in progress (since we're in RDP2), which I'll review along with the code.

@aghaisas Can I ask you to also review it?

-------------

PR: https://git.openjdk.org/jfx/pull/1021


More information about the openjfx-dev mailing list