RFR: 8290765: Remove parent disabled/treeVisible listeners [v4]

Kevin Rushforth kcr at openjdk.org
Fri Feb 3 23:05:03 UTC 2023


On Sat, 28 Jan 2023 16:24:30 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> `Node` adds InvalidationListeners to its parent's `disabled` and `treeVisible` properties and calls its own `updateDisabled()` and `updateTreeVisible(boolean)` methods when the property values change.
>> 
>> These listeners are not required, since `Node` can easily call the `updateDisabled()` and `updateTreeVisible(boolean)` methods on its children, saving the memory cost of maintaining listeners and bindings.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Initialize treeVisible field directly

I took a quick look and it seems fine to me.

I recommend to wait for a day or two to see if @arapte has any additional comments on the changes (since his review is stale).

-------------

PR: https://git.openjdk.org/jfx/pull/841


More information about the openjfx-dev mailing list