[jfx20] RFR: 8301797: Pagination control has the wrong size [v2]

Andy Goryachev angorya at openjdk.org
Fri Feb 3 23:09:30 UTC 2023


> Fixed regression introduced by JDK-8295754, targeting upstream **jfx20 branch**.
> 
> The method PaginationSkin.resetIndexes(true) has been moved to the original position in the constructor, fixing the initialization, while making sure no properties of the control are touched in the constructor (only in install()).
> 
> Added a test case.
> 
> Tested with the PaginationDisappear.java and the LeakTest app
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTestApp.java

Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:

  8301797: review comments

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1021/files
  - new: https://git.openjdk.org/jfx/pull/1021/files/3fbbfccb..a01348e6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1021&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1021&range=00-01

  Stats: 7 lines in 1 file changed: 1 ins; 5 del; 1 mod
  Patch: https://git.openjdk.org/jfx/pull/1021.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/1021/head:pull/1021

PR: https://git.openjdk.org/jfx/pull/1021


More information about the openjfx-dev mailing list