[jfx20] RFR: 8301797: Pagination control has the wrong size [v2]
Andy Goryachev
angorya at openjdk.org
Fri Feb 3 23:09:31 UTC 2023
On Fri, 3 Feb 2023 22:28:06 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8301797: review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/PaginationSkin.java line 197:
>
>> 195: nextStackPane.setVisible(false);
>> 196:
>> 197: resetIndexes(true);
>
> This will end up calling into the control in a couple places, which the PR description says you are trying to avoid.
true, but since it sets to the same value it will be a no-op
-------------
PR: https://git.openjdk.org/jfx/pull/1021
More information about the openjfx-dev
mailing list