[jfx20] RFR: 8301797: Pagination control has the wrong size

Andy Goryachev angorya at openjdk.org
Fri Feb 3 23:09:56 UTC 2023


On Fri, 3 Feb 2023 23:05:43 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Fixed regression introduced by JDK-8295754, targeting upstream **jfx20 branch**.
>> 
>> The method PaginationSkin.resetIndexes(true) has been moved to the original position in the constructor, fixing the initialization, while making sure no properties of the control are touched in the constructor (only in install()).
>> 
>> Added a test case.
>> 
>> Tested with the PaginationDisappear.java and the LeakTest app
>> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTestApp.java
>
> The changes you just made look good to me, since everything is now internally consistent. I'll retest and then finish my review.

Thank you, @kevinrushforth .

-------------

PR: https://git.openjdk.org/jfx/pull/1021


More information about the openjfx-dev mailing list