RFR: 8290765: Remove parent disabled/treeVisible listeners [v5]
Michael Strauß
mstrauss at openjdk.org
Fri Feb 3 23:34:57 UTC 2023
On Fri, 3 Feb 2023 23:31:24 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> `Node` adds InvalidationListeners to its parent's `disabled` and `treeVisible` properties and calls its own `updateDisabled()` and `updateTreeVisible(boolean)` methods when the property values change.
>>
>> These listeners are not required, since `Node` can easily call the `updateDisabled()` and `updateTreeVisible(boolean)` methods on its children, saving the memory cost of maintaining listeners and bindings.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>
> improved tests, changed foreach loop
I've extended the tests to check for the other direction as well.
@hjohn @nlisker can you re-review?
-------------
PR: https://git.openjdk.org/jfx/pull/841
More information about the openjfx-dev
mailing list