RFR: 8173321: Click on trough has no effect when cell height > viewport [v3]
Kevin Rushforth
kcr at openjdk.org
Sat Feb 4 15:17:55 UTC 2023
On Sun, 22 Jan 2023 15:34:25 GMT, JoachimSchriek <duke at openjdk.org> wrote:
>> This is my (Joachim.Schriek at gmx.de) first contribution to openjfx. My Contributor Agreement is signed but still in review.
>> So please be patient with an absolute beginner as contributor ... .
>> The work of this pull request was fully done in my spare time.
>>
>> I first filed the bug myself in 2017. I had begun working with JavaFX in 2014.
>>
>> The two changes address the two problems mentioned in JDK-8173321:
>> - Using a JavaFX TableView, a click on the right trough has no effect when the cell height of the cell currently displayed is higher than viewport height
>> - The ScrollBar ist displayed with a minimal height.
>>
>> The changes were tested and ran well with Java 17 and the current master branch of openjfx.
>
> JoachimSchriek has updated the pull request incrementally with one additional commit since the last revision:
>
> Deleted trailing whitespace
Reviewers: @aghaisas @andy-goryachev-oracle
I'll add a few comments, but will rely on Ajit and Andy to formally review it. @johanvos might want to take a look as well, since he has recently fixed several VirtualFlow bugs.
@JoachimSchriek You will need to change the title of this PR to exactly match the JBS title (see the note from the Skara bot in the Description).
-------------
PR: https://git.openjdk.org/jfx/pull/985
More information about the openjfx-dev
mailing list