RFR: 8173321: TableView: Click on right trough has no effect when cell height is higher than viewport height [v7]

JoachimSchriek duke at openjdk.org
Mon Feb 6 14:15:17 UTC 2023


> This is my (Joachim.Schriek at gmx.de) first contribution to openjfx. My Contributor Agreement is signed but still in review.
> So please be patient with an absolute beginner as contributor ... .
> The work of this pull request was fully done in my spare time.
> 
> I first filed the bug myself in 2017. I had begun working with JavaFX in 2014.
> 
> The two changes address the two problems mentioned in JDK-8173321:
> - Using a JavaFX TableView, a click on the right trough has no effect when the cell height of the cell currently displayed is higher than viewport height
> - The ScrollBar ist displayed with a minimal height.
> 
> The changes were tested and ran well with Java 17 and the current master branch of openjfx.

JoachimSchriek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Merge branch 'openjdk:master' into master
 - Restore original VirtualFlow.java
 - Changes made following findings from review
 - Deleted trailing whitespace
 - Committed Test Case for [openjdk/jfx] 8173321: Click on trough has no
   effect when cell height > viewport (PR #985):
 - Replaces Tabs with Spaces
 - JDK-8173321: Click on trough has no effect when cell height > viewport
   height

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/985/files
  - new: https://git.openjdk.org/jfx/pull/985/files/a316200e..62606f41

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=985&range=06
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=985&range=05-06

  Stats: 202484 lines in 5685 files changed: 120624 ins; 43383 del; 38477 mod
  Patch: https://git.openjdk.org/jfx/pull/985.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/985/head:pull/985

PR: https://git.openjdk.org/jfx/pull/985


More information about the openjfx-dev mailing list