[jfx20] RFR: 8293587: Fix mistakes in FX API docs [v3]

Nir Lisker nlisker at openjdk.org
Tue Feb 7 17:16:48 UTC 2023


On Tue, 7 Feb 2023 12:17:43 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Update modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
>>    
>>    Co-authored-by: John Hendrikx <john.hendrikx+github at gmail.com>
>>  - Update modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
>>    
>>    Co-authored-by: John Hendrikx <john.hendrikx+github at gmail.com>
>>  - Update modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
>>    
>>    Co-authored-by: John Hendrikx <john.hendrikx+github at gmail.com>
>
> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 3277:
> 
>> 3275:         private void processDropEnd(DragEvent de) {
>> 3276:             if (source == null) {
>> 3277:                 System.out.println("Scene.DnDGesture.processDropEnd() - UNEXPECTED - source is NULL");
> 
> This reminds me... I see that this warning is printed to `System.out`. I plan to file a follow-up cleanup bug (not for `jfx20`) to fix this, here and in other places, since runtime warnings should be printed to `System.err` (or else logged using the platform logger, but that would be a larger change, so I expect we'll opt for the simple substitution).

I never understood when something should be logged vs. printed. And do we ever print to `out`?

-------------

PR: https://git.openjdk.org/jfx/pull/1025


More information about the openjfx-dev mailing list