RFR: 8230833: LabeledSkinBase computes wrong height with ContentDisplay.GRAPHIC_ONLY [v5]
Karthik P K
kpk at openjdk.org
Wed Feb 8 12:19:34 UTC 2023
> Ignore text condition was not considered in `computePrefHeight` method while calculating the Label height.
>
> Added `isIgnoreText` condition in `computePrefHeight` method while calculating Label height.
>
> Tests are present for all the ContentDisplay types. Modified tests which were failing because of the new height value getting calculated.
Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
Addressing review comments
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/996/files
- new: https://git.openjdk.org/jfx/pull/996/files/1b868a6f..ede9c535
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=996&range=04
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=996&range=03-04
Stats: 9 lines in 1 file changed: 3 ins; 0 del; 6 mod
Patch: https://git.openjdk.org/jfx/pull/996.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/996/head:pull/996
PR: https://git.openjdk.org/jfx/pull/996
More information about the openjfx-dev
mailing list