RFR: 8088998: XYChart: duplicate child added exception when remove & add a series in several charts [v2]

[Karthik P K]

On Wed, 8 Feb 2023 17:31:08 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Renamed system test file
>>  - Fixing issue in all XYCharts
>
> modules/javafx.controls/src/main/java/javafx/scene/chart/AreaChart.java line 72:
> 
>> 70:     // -------------- PRIVATE FIELDS ------------------------------------------
>> 71: 
>> 72:     /** A multiplier for teh Y values that we store for each series, it is used to animate in a new series */
> 
> while we are at it, could we fix the comment "teh" -> "the"

Fixed this typo

> tests/system/src/test/java/test/javafx/scene/control/XYChartExceptionOnAddingRemovedSeriesTest.java line 94:
> 
>> 92:     @Test
>> 93:     public void testLineChartExceptionOnAddingRemovedSeries() throws Throwable {
>> 94:         Thread.sleep(1000); // Wait for stage to layout
> 
> I wonder if there is a better way of doing this, other than a long sleep?  Perhaps use some kind of a concurrency primitive?

Updated code to wait on `startupLatch` instead of sleep.

-------------

PR: https://git.openjdk.org/jfx/pull/1015