RFR: 8230833: LabeledSkinBase computes wrong height with ContentDisplay.GRAPHIC_ONLY [v6]
Karthik P K
kpk at openjdk.org
Fri Feb 10 05:11:53 UTC 2023
On Thu, 9 Feb 2023 14:40:15 GMT, Karthik P K <kpk at openjdk.org> wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while calculating Label height.
>>
>> Tests are present for all the ContentDisplay types. Modified tests which were failing because of the new height value getting calculated.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>
> Optimizing computePrefWidth method
Thanks Andy.
@aghaisas and @hjohn, since there has been code changes after your approval, looks like the PR is not getting added with ready label.
Could you please review and approve the changes.
-------------
PR: https://git.openjdk.org/jfx/pull/996
More information about the openjfx-dev
mailing list