RFR: 8088998: XYChart: duplicate child added exception when remove & add a series in several charts [v2]

Karthik P K kpk at openjdk.org
Fri Feb 10 05:28:09 UTC 2023


On Thu, 9 Feb 2023 16:27:46 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Updated code to set the handler in function annotated with @BeforeClass and cleaned up in  @AfterClass.
>
> I am not sure setting uncaught exception handler in @BeforeClass and clearing it in @AfterClass is correct.
> The junit framework may execute these tests in parallel or sequentially (I think these are actually executed sequentially), but I would not rely on the fact that the individual tests will be executed in the same thread.
> 
> So I'd suggest to move this code to @After and @Before, just like BehaviorCleanupTest and other tests.

Moved the code to @Before and @After. Please check

-------------

PR: https://git.openjdk.org/jfx/pull/1015


More information about the openjfx-dev mailing list