Integrated: 8230833: LabeledSkinBase computes wrong height with ContentDisplay.GRAPHIC_ONLY

Karthik P K kpk at openjdk.org
Fri Feb 10 11:17:59 UTC 2023


On Mon, 16 Jan 2023 10:46:12 GMT, Karthik P K <kpk at openjdk.org> wrote:

> Ignore text condition was not considered in `computePrefHeight` method while calculating the Label height.
> 
> Added `isIgnoreText` condition in `computePrefHeight` method while calculating Label height.
> 
> Tests are present for all the ContentDisplay types. Modified tests which were failing because of the new height value getting calculated.

This pull request has now been integrated.

Changeset: d3654e3a
Author:    Karthik P K <kpk at openjdk.org>
Committer: Ajit Ghaisas <aghaisas at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/d3654e3aff06a70246ba969698ae2a04d92972c0
Stats:     84 lines in 2 files changed: 27 ins; 24 del; 33 mod

8230833: LabeledSkinBase computes wrong height with ContentDisplay.GRAPHIC_ONLY

Reviewed-by: aghaisas, jhendrikx, angorya

-------------

PR: https://git.openjdk.org/jfx/pull/996


More information about the openjfx-dev mailing list